Add display attributes for OpenAPI OperationID's #172
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,7 +158,11 @@ func pathsRole(b *GcpAuthBackend) []*framework.Path { | |
|
|
||
| paths := []*framework.Path{ | ||
| { | ||
| Pattern: fmt.Sprintf("role/%s", framework.GenericNameRegex("name")), | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationPrefix: operationPrefixGoogleCloud, | ||
| OperationSuffix: "role", | ||
| }, | ||
| Fields: roleFieldSchema, | ||
| ExistenceCheck: b.pathRoleExistenceCheck, | ||
| Callbacks: map[logical.Operation]framework.OperationFunc{ | ||
|
|
@@ -173,6 +177,11 @@ func pathsRole(b *GcpAuthBackend) []*framework.Path { | |
| // Paths for listing roles | ||
| { | ||
| Pattern: "role/?", | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationPrefix: operationPrefixGoogleCloud, | ||
| OperationVerb: "list", | ||
| OperationSuffix: "roles", | ||
| }, | ||
| Callbacks: map[logical.Operation]framework.OperationFunc{ | ||
| logical.ListOperation: b.pathRoleList, | ||
| }, | ||
|
|
@@ -182,6 +191,11 @@ func pathsRole(b *GcpAuthBackend) []*framework.Path { | |
| }, | ||
| { | ||
| Pattern: "roles/?", | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationPrefix: operationPrefixGoogleCloud, | ||
| OperationVerb: "list", | ||
| OperationSuffix: "roles2", | ||
| }, | ||
| Callbacks: map[logical.Operation]framework.OperationFunc{ | ||
| logical.ListOperation: b.pathRoleList, | ||
| }, | ||
|
|
@@ -193,6 +207,11 @@ func pathsRole(b *GcpAuthBackend) []*framework.Path { | |
| // Edit service accounts on an IAM role | ||
| { | ||
| Pattern: fmt.Sprintf("role/%s/service-accounts", framework.GenericNameRegex("name")), | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationPrefix: operationPrefixGoogleCloud, | ||
| OperationVerb: "edit", | ||
| OperationSuffix: "service-accounts-for-role", | ||
| }, | ||
| Fields: map[string]*framework.FieldSchema{ | ||
| "name": { | ||
| Type: framework.TypeString, | ||
|
|
@@ -217,6 +236,11 @@ func pathsRole(b *GcpAuthBackend) []*framework.Path { | |
| // Edit labels on an GCE role | ||
| { | ||
| Pattern: fmt.Sprintf("role/%s/labels", framework.GenericNameRegex("name")), | ||
| DisplayAttrs: &framework.DisplayAttributes{ | ||
| OperationPrefix: operationPrefixGoogleCloud, | ||
| OperationVerb: "edit", | ||
|
There was a problem hiding this comment. This seems like a new OperationVerb, should this be There was a problem hiding this comment. This operation edits the labels with "add" / "remove" arrays. The name is also from the docs |
||
| OperationSuffix: "labels-for-role", | ||
| }, | ||
| Fields: map[string]*framework.FieldSchema{ | ||
| "name": { | ||
| Type: framework.TypeString, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the consistent naming throughout? vs
GCPThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how the plugin is referenced to in the docs. I felt
gcpmight be too obscure but I'm happy to change this if folks feel strongly about it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel too strongly either way but maybe it would make sense to use
gcpsince (1) that is how we reference it everywhere except for the docs and (2) the operationID is an ID so I think the only thing that really matters is uniqueness.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
operationIDis translated directly into method names and struct names in the library generated code. For examplegoogle-cloud-list-roleswould be translated into:vs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks! google-cloud works for me!