Add volume claim annotations #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Thanks for the contribution @echoboomer, we can definitely add this.
This will need basic unit test coverage, which can be found in test/unit. Let me know if you have any questions!
|
@jasonodonnell Thanks for the feedback! I have added unit tests to cover both cases regarding $ bats ./test/unit/server-statefulset.bats
...
69 tests, 0 failuresI hope this follows the formatting expected. Please let me know if there are any further required changes. Thank you! |
echoboomer
force-pushed
the
add-volumeClaim-annotations
branch
from
c777b34 to
65e9dd8
Compare
|
Hey @jasonodonnell - just circling back to see if I need to add anything else here. Thank you! |
jasonodonnell
approved these changes
Aug 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: When using a tool like ArgoCD,
PersistentVolumeClaimresources show up as "needs pruning" since they are generated via templating instead of factored in at build time. Despite the use of values that indicate the creation of these claims is a desirable outcome, they simply show up as "out of sync."Adding the ability to pass annotations into these objects would allow the use of annotations to tell ArgoCD to simply ignore them. This is admittedly a fringe use case, but could provide useful either way. These were created separately to allow turning either of them on or off, but the initial approach was to just put them under
global, but that seemed wrong.Unit tests pass:
303 tests, 0 failures, however no net new unit tests have been added as part of this PR. I'm happy to write one if it's necessary for this addition.Thanks for your time!