Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vault Helm ent support, service discovery #250

Merged
merged 7 commits into from
Apr 9, 2020
Merged

Conversation

jasonodonnell
Copy link
Contributor

This adds support for Vault Helm enterprise by adding:

  • internal service so pods can communicate directly with each other
  • new environment variables for better clustering setup
  • acceptance tests for DR and perf replication
  • new services for HA mode (service discovery labels)

Will change the image to the official 1.4.0 image when it's released. Keeping it as a release candidate for evaluating this PR (there's 1.4.0 hard requirements).

@jasonodonnell jasonodonnell requested a review from tvoran April 6, 2020 16:57
@jasonodonnell
Copy link
Contributor Author

Initial doc PR here: hashicorp/vault#8678

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me! The tests all passed, and I ran through a couple of the raft examples in the docs PR.

Just some comments about the image tag; once 1.4.0 is released I'm guessing we'll want to use that.

test/acceptance/server-ha-enterprise-dr.bats Outdated Show resolved Hide resolved
test/acceptance/server-ha-enterprise-dr.bats Outdated Show resolved Hide resolved
test/acceptance/server-ha-enterprise-perf.bats Outdated Show resolved Hide resolved
test/acceptance/server-ha-enterprise-perf.bats Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
@jasonodonnell jasonodonnell merged commit 6d5a217 into master Apr 9, 2020
@jasonodonnell jasonodonnell deleted the 1.4.0-ent-beta branch April 9, 2020 13:27
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
* Add Vault Helm ent support, service discovery

* Fix unit test

* Update test/acceptance/server-ha-enterprise-dr.bats

Co-Authored-By: Theron Voran <[email protected]>

* Update test/acceptance/server-ha-enterprise-dr.bats

Co-Authored-By: Theron Voran <[email protected]>

* Update test/acceptance/server-ha-enterprise-perf.bats

Co-Authored-By: Theron Voran <[email protected]>

* Update test/acceptance/server-ha-enterprise-perf.bats

Co-Authored-By: Theron Voran <[email protected]>

* Update values.yaml

Co-Authored-By: Theron Voran <[email protected]>

Co-authored-by: Theron Voran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants