VAULT-28317: Fix issue with lowercasing of HCP resources #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
commented
Jul 2, 2024
| @@ -382,7 +382,7 @@ func Test_getProject(t *testing.T) { | |||
| // Test multiple projects | |||
| // UI interaction required | |||
| "multiple projects": { | |||
| userInputProjectName: "mock-project-2\n", | |||
| userInputProjectName: "MOCK_-project-2\n", | |||
There was a problem hiding this comment.
These tests would fail before the fix, and are valid project names.
ccapurso
approved these changes
Jul 2, 2024
peteski22
approved these changes
Jul 4, 2024
biazmoreira
approved these changes
Jul 4, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an issue where the names of HCP resources would be lowercased. Since HCP resources are case sensitive, this means that if you have e.g. "foo" and "FOO", you would be unable to access one of them.
Likewise, if you had a project called "FOO", you could previously only access it via typing "foo", which was a pain point forsome users.
This could affect a customer that was previously accessing "FOO" by typing "foo", but ultimately that's on them, since these resources are case sensitive.
I tested this in Vault to fix issues found in
vault hcp connectusing the following:replace github.com/hashicorp/vault-hcp-lib => ../vault-hcp-libOnce merged, I'll update this in Vault, and backport it etc.
Contributor Checklist