add error handling for creating and locked clusters #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biazmoreira
reviewed
Jan 22, 2024
connect.go
Outdated
Comment on lines
339
to
343
| if *cluster.State == hcpvsm.HashicorpCloudVault20201125ClusterStateLOCKED || *cluster.State == hcpvsm.HashicorpCloudVault20201125ClusterStateLOCKING { | ||
| return "", errors.New("cluster is locked") | ||
| } else if *cluster.State == hcpvsm.HashicorpCloudVault20201125ClusterStateCREATING { | ||
| return "", errors.New("cluster is still being created") | ||
| } else if *cluster.State != hcpvsm.HashicorpCloudVault20201125ClusterStateRUNNING { |
There was a problem hiding this comment.
Shouldn't we replace it with a switch case?
There was a problem hiding this comment.
I attempted to refactor this from if/else if to a switch/case. Unfortunately, it looks roughly the same since we cannot switch based on the value of *cluster.State. I can create a variable for the state though to prevent multiple dereferences.
biazmoreira
approved these changes
Jan 22, 2024
divyaac
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The options provided in the Choose a cluster prompt are not filtered and thus a user may be provided options where the clusters are still being created or are API locked. A user will be presented with an error
cluster is not runningif they choose a cluster in any state other than running.This PR introduces error handling for the
CREATING,LOCKING, andLOCKEDcluster states.Related Issues/Pull Requests
This will be incorporated with a Vault PR once approved and merged