HVT-4955: Add connect command flag validation (#32)

* add connect flag validation

* fmt

config.go

@@ -18,7 +18,7 @@ const (
 	defaultDirectory     = ".config/hcp/hvd"
 	testDirectory        = "hcptest"
 	fileName             = "hvd_proxy_config.json"
-	directoryPermissions = 0755
+	directoryPermissions = 0o755
 
 	envVarCacheTestMode = "HCP_CACHE_TEST_MODE"
 )

config_test.go

@@ -37,7 +37,6 @@ func Test_GetHCPConfiguration(t *testing.T) {
 				assert.Nil(t, tk)
 				assert.Nil(t, err)
 			}
-
 		})
 	}
 }

connect.go

@@ -101,7 +101,12 @@ func (c *HCPConnectCommand) setupClients() error {
 
 	if c.rmOrgClient == nil && c.rmProjClient == nil && c.vsClient == nil {
 		opts = []config.HCPConfigOption{config.FromEnv()}
-		if c.flagClientID != "" && c.flagSecretID != "" {
+
+		if c.flagClientID != "" && c.flagSecretID == "" {
+			return errors.New("secret-id is required when client-id is provided")
+		} else if c.flagSecretID != "" && c.flagClientID == "" {
+			return errors.New("client-id is required when secret-id is provided")
+		} else if c.flagClientID != "" && c.flagSecretID != "" {
 			opts = append(opts, config.WithClientCredentials(c.flagClientID, c.flagSecretID))
 			opts = append(opts, config.WithoutBrowserLogin())
 		}

connect_test.go

@@ -29,6 +29,52 @@ func testHCPConnectCommand() (*cli.MockUi, *HCPConnectCommand) {
 	return ui, &HCPConnectCommand{Ui: ui}
 }
 
+func Test_HCPConnect_FlagValidation(t *testing.T) {
+	cases := []struct {
+		name  string
+		flags []string
+		code  int
+		error string
+	}{
+		{
+			name:  "invalid flags",
+			flags: []string{"-invalid", "abc123"},
+			code:  1,
+			error: "flag provided but not defined: -invalid",
+		},
+		{
+			name:  "only client-id provided",
+			flags: []string{"-client-id", "abc123"},
+			code:  1,
+			error: "secret-id is required when client-id is provided",
+		},
+		{
+			name:  "only secret-id provided",
+			flags: []string{"-secret-id", "abc123"},
+			code:  1,
+			error: "client-id is required when secret-id is provided",
+		},
+	}
+
+	for _, tc := range cases {
+		tc := tc
+
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			ui, cmd := testHCPConnectCommand()
+			result := cmd.Run(tc.flags)
+			output := ui.OutputWriter.String() + ui.ErrorWriter.String()
+
+			assert.Equal(t, tc.code, result)
+
+			if tc.error != "" {
+				assert.Contains(t, output, tc.error)
+			}
+		})
+	}
+}
+
 func Test_HCPConnectCommand(t *testing.T) {
 	_, cmd := testHCPConnectCommand()
 
@@ -212,7 +258,6 @@ func Test_getOrganization(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func Test_getProject(t *testing.T) {
@@ -333,7 +378,6 @@ func Test_getProject(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func Test_getCluster(t *testing.T) {

disconnect.go

@@ -12,9 +12,7 @@ import (
 	"github.com/hashicorp/cli"
 )
 
-var (
-	_ cli.Command = (*HCPDisconnectCommand)(nil)
-)
+var _ cli.Command = (*HCPDisconnectCommand)(nil)
 
 type HCPDisconnectCommand struct {
 	Ui cli.Ui

testhelpers.go

@@ -4,8 +4,9 @@
 package vaulthcplib
 
 import (
-	"golang.org/x/oauth2"
 	"time"
+
+	"golang.org/x/oauth2"
 )
 
 type TestTokenSource struct{}