Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow changing default Vault address and Kubernetes mount #96

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

isugimpy
Copy link
Contributor

This PR is a step toward #82 in that it allows setting the Vault address and Kubernetes mount globally, instead of them being set as constants in the code. It does not remove the ability for users to specify vaultAddress or vaultKubernetesMountPath on their SecretProviderClass. This is a big advantage because it allows the cluster operator to set sane defaults for a given cluster that users won't have to be aware of to use the CSI.

@hashicorp-cla
Copy link

hashicorp-cla commented May 15, 2021

CLA assistant check
All committers have signed the CLA.

@isugimpy
Copy link
Contributor Author

Oh, and just to clarify since I hadn't said so explicitly: I've tested this on a live cluster and everything seems to work as expected.

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this! It all looks good to me, it's just raised one existing issue with the flags that I'd like to fix before we add any more with underscores.

Please could you also add a changelog entry? Other than that, I think the test coverage looks good so this is pretty much ready to land.

main.go Outdated Show resolved Hide resolved
@isugimpy isugimpy requested a review from tomhjp May 24, 2021 16:53
@isugimpy
Copy link
Contributor Author

Fixed things up in the requested way. If possible, after this is merged I'd greatly appreciate y'all cutting a release for this. We're wanting to start using this in production, and it'd be super helpful to not have to run a forked binary instead of the official release.

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It shouldn't be long to wait until the next release

@tomhjp
Copy link
Contributor

tomhjp commented Jun 1, 2021

Apologies I butchered the resolve conflicts step a bit after merging the other open PR, hopefully can get a set of green CI checks and merge this shortly.

@isugimpy
Copy link
Contributor Author

isugimpy commented Jun 1, 2021

No worries, greatly appreciate the review and approval!

@tomhjp tomhjp merged commit f9ff525 into hashicorp:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants