Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vault namespaces #84

Merged
merged 7 commits into from
Apr 12, 2021
Merged

Add support for Vault namespaces #84

merged 7 commits into from
Apr 12, 2021

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Apr 9, 2021

Add support for Vault namespaces. Addresses #65.

  • New config option "vaultNamespace" in SecretProviderClass
  • Fix e2e test installation of vault-csi-provider to use locally built image 🤦
  • New e2e test for namespaces
  • Switch all e2e tests to use vault-enterprise, which lasts 6h without a license
  • Trim some small unnecessary dependencies

@tomhjp tomhjp requested review from tvoran and jasonodonnell April 9, 2021 14:59
internal/config/config_test.go Outdated Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants