Add go build version to version info #62
Conversation
| LDFLAGS?="-X github.com/hashicorp/secrets-store-csi-driver-provider-vault/internal/version.BuildVersion=$(IMAGE_VERSION) -X github.com/hashicorp/secrets-store-csi-driver-provider-vault/internal/version.BuildDate=$(BUILD_DATE) -extldflags "-static"" | ||
| LDFLAGS?="-X 'github.com/hashicorp/secrets-store-csi-driver-provider-vault/internal/version.BuildVersion=$(IMAGE_VERSION)' \ | ||
| -X 'github.com/hashicorp/secrets-store-csi-driver-provider-vault/internal/version.BuildDate=$(BUILD_DATE)' \ | ||
| -X 'github.com/hashicorp/secrets-store-csi-driver-provider-vault/internal/version.GoVersion=$(shell go version)' \ |
There was a problem hiding this comment.
Will this work on windows (the shell command)? Would it be better to set this version as a variable like we do for BUILD_DATE? Granted I see now that we do shell for IMAGE_VERSION as well
There was a problem hiding this comment.
Thanks for pointing this out, I hadn't really considered that. I don't have a Windows machine to test on, but I think it may work? As shell is just a Makefile function that says "use the default shell" and I believe it will use cmd.exe and I think go version will work? There are a lot of guesses there, but as mentioned it doesn't change compatibility and Windows support is a fair way off for now, so I'll leave this one as-is for this PR.
Makefile shell docs for reference
Choosing the shell docs which make it sound way more complicated than I said above 😱
Following up on a comment from #61.
./_output/secrets-store-csi-driver-provider-vault_darwin_amd64_0.0.7 --version {"version":"0.0.7","buildDate":"2021-02-04-15:38","goVersion":"go version go1.15.7 darwin/amd64","minDriverVersion":"v0.0.17"}