Bump got from 11.8.5 to 11.8.6 #492
Conversation
|
|
|
Hi @calvn , could you please take a look on this PR? Since all check are green it would be nice to drop this in :-) |
dist/index.js
Outdated
| @@ -3702,6 +3702,7 @@ function asPromise(normalizedOptions) { | |||
| request._beforeError(new types_1.HTTPError(response)); | |||
| return; | |||
| } | |||
| request.destroy(); | |||
There was a problem hiding this comment.
Please revert the changes to dist/index.js. We do not commit directly to this file except when the team is doing a release.
There was a problem hiding this comment.
Ah, my apologies, I didn't realize! I pushed a commit removing this particular change
There was a problem hiding this comment.
Hey @nafarlee thanks for taking care of this! The fix will be included in the upcoming release which will hopefully address the issue for good for everyone. Cheers.
|
@maxcoulombe Glad I could help! |
Hi @maxcoulombe (apologies for "reviving" a closed pull request), when is the next upcoming release planned? We're bit by the problem solved by this change regularly, and it'd be great if we could benefit from this change. Thnx! |
Closes #445
The cause was an underlying issue in
got(sindresorhus/got#1489) which was addressed by a PR back in November (sindresorhus/got#2187).[email protected]contains the fix and is a simple upgrade, especially when compared to upgrading to[email protected]or[email protected](as recommended by #457).