Fix e2e CI failure from "Test that overwrite env var works in nested action (#453)" #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vault-action into add-e2e-test-override-env-var
thyton
changed the title
thyton
changed the title
thyton
changed the title
fairclothjm
reviewed
Jun 13, 2023
| @@ -162,6 +162,22 @@ jobs: | |||
| /cubbyhole/test foo ; | |||
| /cubbyhole/test zip | NAMED_CUBBYSECRET ; | |||
|
|
|||
| - name: Test Vault Action Overwrites Env Vars In Subsequent Action (part 1/2) | |||
There was a problem hiding this comment.
Maybe we should add a comment that the ordering of these two tests matters and they should come before the Verify Vault Action Outputs step?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.