-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9298: Compute a correct path to the current WSL instance #9300
Conversation
|
The implementation has been changed based on investigation I've described in microsoft/WSL#2578 (comment). |
@BR0kEN- Thanks for this PR and the underlying investigation to create it! Once I have validated the functionality on a few versions of win10, I'll get it approved and merged. |
Hi there, checked it on Win10, version 10.0.16299.192. Works well. |
My tests, unfortunately, were on the same build of Win10. |
@BR0kEN- Hi and thanks again for all the hard work you put into this PR. It is greatly appreciated. I'm going to close this PR in favor of #9525 which adds in support for the original lxrun generated WSL instance types and adds a bit of spec coverage. It is built directly on top of your changes, so even though this PR is being closed, your changes will still be getting merged. Thanks again! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
#9298