Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9298: Compute a correct path to the current WSL instance #9300

Closed
wants to merge 8 commits into from
Closed

#9298: Compute a correct path to the current WSL instance #9300

wants to merge 8 commits into from

Conversation

BR0kEN-
Copy link
Contributor

@BR0kEN- BR0kEN- commented Dec 25, 2017

@BR0kEN-
Copy link
Contributor Author

BR0kEN- commented Dec 25, 2017

Just checked this on SUSE Server and it turned out that some tweaks were required.

The previous script for obtaining Linux distro:

python -c "import platform;print(platform.linux_distribution()[0]"

And the new one:

python -c "import platform;print(platform.linux_distribution()[0].split(' ')[0])"

wsl-multi

@BR0kEN-
Copy link
Contributor Author

BR0kEN- commented Dec 26, 2017

The PR brings not an elegant way of solving the problem but, apparently, it works.

Checked on three WSL distros: SUSE Server (the new method linux_distro will return SUSE), openSUSE (linux_distro -> openSUSE) and Ubuntu (linux_distro -> Ubuntu).

Of course, as said in the microsoft/WSL#2578 (comment), there could be a custom distro that won't be handled in that way, but for now this approach is multi-environment at least.

@BR0kEN-
Copy link
Contributor Author

BR0kEN- commented Dec 26, 2017

The implementation has been changed based on investigation I've described in microsoft/WSL#2578 (comment).

@chrisroberts
Copy link
Member

@BR0kEN- Thanks for this PR and the underlying investigation to create it! Once I have validated the functionality on a few versions of win10, I'll get it approved and merged.

@timur-hilmutdinov
Copy link

Hi there, checked it on Win10, version 10.0.16299.192. Works well.

@BR0kEN-
Copy link
Contributor Author

BR0kEN- commented Jan 17, 2018

My tests, unfortunately, were on the same build of Win10.

@chrisroberts chrisroberts added this to the 2.0.3 milestone Jan 30, 2018
@chrisroberts
Copy link
Member

@BR0kEN- Hi and thanks again for all the hard work you put into this PR. It is greatly appreciated. I'm going to close this PR in favor of #9525 which adds in support for the original lxrun generated WSL instance types and adds a bit of spec coverage. It is built directly on top of your changes, so even though this PR is being closed, your changes will still be getting merged.

Thanks again!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants