guests/redhat: Don't error if ifdown fails [GH-2614] #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I think we just put retries all over the place to be resilient to transient failures in the case of idempotent operations. I think here would be fine. But I'm okay merging this without. |
mitchellh
added a commit
that referenced
this pull request
Dec 11, 2013
guests/redhat: Don't error if ifdown fails [GH-2614]
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fix for [GH-2614].
Removed retrying of ifdown on the basis that in most cases the interface is probably missing and it adds an unnecessary 4 seconds to the setup time for the VM. The case where the interface is present and being removed by a config change would appear to be quite rare.
If someone can come up with a good way to distinguish both error cases I can to implement retrying in a more clever way.