Update provider/virtualbox to allow paused state when booting vm #13496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroberts
requested changes
Sep 10, 2024
allisonlarson
force-pushed
the
allison-virtualbox-state-update
branch
from
72a8021
to
1347f70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a virtualbox vm is booting initially, allow it to enter the
:pausedstate and wait until a new state is entered or the boot_timeout is reached. This allows the GUI menu to be accessed and state selected before it errors, but to still error as expected if the outcome of the selection moves the vm to an invalid state. This matches how previous versions of virtualbox behaved, before the:pausedstate was introduced.Also adds some simple tests for
WaitForCommunicator, which came up as I was investigating different ways to address the issuefixes #13410