Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tls_cert_request to be a data source #7469

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Conversation

apparentlymart
Copy link
Contributor

This resource (unlike the others in this provider) isn't stateful, so it is a good candidate to be a data source.

The old resource form is preserved via the standard shim in helper/schema, which will generate a deprecation warning but will still allow the resource to be used.

This resource (unlike the others in this provider) isn't stateful, so it
is a good candidate to be a data source.

The old resource form is preserved via the standard shim in helper/schema,
which will generate a deprecation warning but will still allow the
resource to be used.
@jen20
Copy link
Contributor

jen20 commented Jul 8, 2016

LGTM - we have an unrelated failing TLS acceptance test though: TestLocallySignedCert.

@jen20 jen20 merged commit 46e3cac into master Jul 8, 2016
@jen20 jen20 deleted the f-tls-data-source branch July 8, 2016 16:07
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants