provider/aws: AWS API Gateway request parameters json #6501
Conversation
gthole
changed the title
|
👍 🎆 I neeeed it |
|
👍 |
| @@ -134,6 +140,14 @@ func resourceAwsApiGatewayMethodUpdate(d *schema.ResourceData, meta interface{}) | |||
| operations = append(operations, expandApiGatewayRequestResponseModelOperations(d, "request_models", "requestModels")...) | |||
| } | |||
|
|
|||
| if d.HasChange("request_parameters_in_json") { | |||
| ops, err := expandApiGatewayMethodResponseParametersJSONOperations(d, "request_parameters_in_json", "requestParameters") | |||
There was a problem hiding this comment.
I think we should rename the function to make it more accurate:
expandApiGatewayMethodResponseParametersJSONOperations => expandApiGatewayMethodParametersJSONOperations
(i.e. it is now being used for both response and request parameters so it should be called accordingly)
There was a problem hiding this comment.
and also there are two error messages inside the body of that function that should be changed accordingly too, so they're reflecting the reality.
|
I'm currently running acceptance tests for API Gateway, but the code is looking good. ⏳ |
* Update docs with new parameters * Add request parameters as JSON * Update function name and error statements
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Add the ability to specify request parameters on API Gateway Method and Integration resources, which achieves parity with MethodResponse and IntegrationResponse resources and allows incoming headers and query string parameters to be passed to the backend controller.
This change is a straight extension of the work done in #6344.