Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacks: add deferred to protobuf #34880

Merged
merged 4 commits into from
Apr 2, 2024
Merged

stacks: add deferred to protobuf #34880

merged 4 commits into from
Apr 2, 2024

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Mar 25, 2024

Adds just the protobuf definitions for deferred actions.

Fixes #

Target Release

1.8.x

Draft CHANGELOG entry

NEW FEATURES

  • stacks: add deferred actions to provider protocol

Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/plugin-protocol/tfplugin5.5.proto Outdated Show resolved Hide resolved
docs/plugin-protocol/tfplugin6.5.proto Outdated Show resolved Hide resolved
docs/plugin-protocol/tfplugin6.6.proto Show resolved Hide resolved
@DanielMSchmidt
Copy link
Contributor Author

Oh these files are symlinked, that explains why I edited the wrong files 🤦

in preparation for adding fields related to deferred actions
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'm talking to the devex team tomorrow, so we should just hold off on merging this until we've got final sign off that this is all good. I'll approve after I've spoken to them - I don't anticipate any changes though.

docs/plugin-protocol/tfplugin5.6.proto Outdated Show resolved Hide resolved
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't need to change UpgradeResourceState. I've added comments to the exact places in tfplugin6. You'll need to make equivalent changes to tfplugin5.

docs/plugin-protocol/tfplugin6.6.proto Outdated Show resolved Hide resolved
docs/plugin-protocol/tfplugin6.6.proto Outdated Show resolved Hide resolved
UpgradeResourceState is offline; it does not need a configured provider

therefore it can not be deferred
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I've tagged in Brian and Austin in case they want to have a final look / say, but otherwise good to merge. You can probably just merge this when you're back after Easter!

@austinvalle
Copy link
Member

This looks good to me. I've tagged in Brian and Austin in case they want to have a final look / say, but otherwise good to merge. You can probably just merge this when you're back after Easter!

@liamcervante & @DanielMSchmidt

@bflad and I talked with @alexsomesan, @radditude, and @nfagerlund while you both were out. Brian and I want to propose some additional changes to the protocol. (as of now, only additive to what's in this PR, so not sure if that makes it a blocker)

Our main goal is to add some bits to the protocol (specifically ConfigureProvider and possibly GetProviderSchema) for the PROVIDER_CONFIG_UNKNOWN scenario, to protect existing resources that rely on provider configs being fully known to successfully plan.

We should sync up next week when you both get back. (I'm not 100% sure who from Core wants to join so I'll wait to schedule something before playing calendar roulette due to the TZ differences 😆 )

@DanielMSchmidt
Copy link
Contributor Author

@austinvalle Reading through the proposed protocol changes they seem to be only additive to this PR, I'll therefore go ahead and merge this PR and we can do follow up once the discussion settles down on the to be added changes 👍

@DanielMSchmidt DanielMSchmidt merged commit 561e74b into main Apr 2, 2024
10 checks passed
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented May 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants