-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stacks: add deferred to protobuf #34880
Conversation
b5d5396
to
3198f88
Compare
3198f88
to
43ec6e7
Compare
43ec6e7
to
1f316b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the symlinked files in https://github.com/hashicorp/terraform/tree/main/internal/tfplugin5 and https://github.com/hashicorp/terraform/tree/main/internal/tfplugin6 so they point to the latest .proto files as well.
1f316b5
to
70bc75d
Compare
Oh these files are symlinked, that explains why I edited the wrong files 🤦 |
70bc75d
to
4ee8d6d
Compare
in preparation for adding fields related to deferred actions
4ee8d6d
to
e650c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'm talking to the devex team tomorrow, so we should just hold off on merging this until we've got final sign off that this is all good. I'll approve after I've spoken to them - I don't anticipate any changes though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we don't need to change UpgradeResourceState. I've added comments to the exact places in tfplugin6. You'll need to make equivalent changes to tfplugin5.
2f0c7ca
to
71873ec
Compare
UpgradeResourceState is offline; it does not need a configured provider therefore it can not be deferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I've tagged in Brian and Austin in case they want to have a final look / say, but otherwise good to merge. You can probably just merge this when you're back after Easter!
@liamcervante & @DanielMSchmidt @bflad and I talked with @alexsomesan, @radditude, and @nfagerlund while you both were out. Brian and I want to propose some additional changes to the protocol. (as of now, only additive to what's in this PR, so not sure if that makes it a blocker) Our main goal is to add some bits to the protocol (specifically We should sync up next week when you both get back. (I'm not 100% sure who from Core wants to join so I'll wait to schedule something before playing calendar roulette due to the TZ differences 😆 ) |
@austinvalle Reading through the proposed protocol changes they seem to be only additive to this PR, I'll therefore go ahead and merge this PR and we can do follow up once the discussion settles down on the to be added changes 👍 |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Adds just the protobuf definitions for deferred actions.
Fixes #
Target Release
1.8.x
Draft CHANGELOG entry
NEW FEATURES