filter computed attrs from ignore_changes=all
#31747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling ignore_changes=all, we must filter computed attributes from the prior state to prevent them showing in the configuration. Since it's not valid for the user to have set computed attributes in the config, the provider should expect to never see any values there. The oversight has only now become apparent, as more providers adopt the plugin-framework which has direct access to the plan-time configuration value.
jbardin
added
the
1.3-backport
kmoe
reviewed
Sep 20, 2022
jbardin
force-pushed
the
jbardin/ignore-changes-all-computed
branch
from
112eb04 to
3e281e1
Compare
alisdair
approved these changes
Sep 28, 2022
|
This was reported internally by the SDK team, I don't think there was a specific GH issue. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
This might be the associated issue you are looking for: hashicorp/terraform-provider-random#302 Similarly down in the comments, hashicorp/terraform-provider-random#325. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling
ignore_changes=all, we must filter computed attributesfrom the prior state to prevent them showing in the configuration. Since
it's not valid for the user to have set computed attributes in the
config, the provider should expect to never see any values there. The
oversight has only now become apparent, as more providers adopt the
plugin-framework which has direct access to the plan-time configuration
value.