Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixes 31700] Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. #31699

Merged
merged 29 commits into from
Jan 26, 2023
Merged

[fixes 31700] Add mTLS support for http backend by way of client cert & key, as well as enterprise cacert. #31699

merged 29 commits into from
Jan 26, 2023

Commits on Dec 15, 2022

  1. Add mTLS support for http backend by way of client cert & key, as wel… 

    …l as enterprise cacert.
    @scr-oath
    Sheridan C Rawlins authored and scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a00a1ab View commit details
    Browse the repository at this point in the history

  2. Fix style.

    @scr-oath
    Sheridan C Rawlins authored and scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8a7f4e9 View commit details
    Browse the repository at this point in the history

  3. Skip cert validation to be sure error is related to missing client ce… 

    …rt; not untrusted server cert.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    eab391b View commit details
    Browse the repository at this point in the history

  4. Remove misplaced err check.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cd46c94 View commit details
    Browse the repository at this point in the history

  5. Fix the size of test using http backend.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0223e3c View commit details
    Browse the repository at this point in the history

  6. Just for correctness, include all certs in the pem encoded cert - som… 

    …etimes certs come with a chain of their signers.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ab1dd2b View commit details
    Browse the repository at this point in the history

  7. Adjusted names as recommended in PR comments.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    985bc53 View commit details
    Browse the repository at this point in the history

  8. Adjusted names to be full-length and more descriptive.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    172f958 View commit details
    Browse the repository at this point in the history

  9. Added full-fledged testing with mTLS http server

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ce5d217 View commit details
    Browse the repository at this point in the history

  10. Fix goimports.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    33031da View commit details
    Browse the repository at this point in the history

  11. Fix the names of the backend config.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c61a9ed View commit details
    Browse the repository at this point in the history

  12. Exclusive lock for write and delete.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fb7e570 View commit details
    Browse the repository at this point in the history

  13. Revert "Fix goimports." 

    This reverts commit 7d40f60.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cfd928a View commit details
    Browse the repository at this point in the history

  14. goimports just for server test.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bbc0478 View commit details
    Browse the repository at this point in the history

  15. Added the go:generation for the mock.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6208901 View commit details
    Browse the repository at this point in the history

  16. Move the TLS configuration out to make it more readable - don't repla… 

    …ce the HTTPClient as the retryablehttp already creates one - just configure its TLS.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6328481 View commit details
    Browse the repository at this point in the history

  17. Just switch the client/data params - felt more natural this way.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2ab36d6 View commit details
    Browse the repository at this point in the history

  18. Update internal/backend/remote-state/http/backend.go 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6f05da8 View commit details
    Browse the repository at this point in the history

  19. Update internal/backend/remote-state/http/testdata/gencerts.sh 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    441edac View commit details
    Browse the repository at this point in the history

  20. Update internal/backend/remote-state/http/backend.go 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    91baacc View commit details
    Browse the repository at this point in the history

  21. Update internal/backend/remote-state/http/backend.go 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    666d7fc View commit details
    Browse the repository at this point in the history

  22. Update internal/backend/remote-state/http/backend.go 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6d6bf19 View commit details
    Browse the repository at this point in the history

  23. Update internal/backend/remote-state/http/backend.go 

    Co-authored-by: kmoe <[email protected]>
    @scr-oath @kmoe
    scr-oath and kmoe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f8a3b8b View commit details
    Browse the repository at this point in the history

  24. the location of the file name is not sensitive.

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    481ad34 View commit details
    Browse the repository at this point in the history

  25. Added error if only one of client_certificate_pem and client_private_… 

    …key_pem are set.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    13bbe7c View commit details
    Browse the repository at this point in the history

  26. Remove testify from test cases; use t.Error* for assert and t.Fatal* … 

    …for require.
    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d4218d1 View commit details
    Browse the repository at this point in the history

  27. Fixed import consistency

    @scr-oath
    scr-oath committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0f7b3c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Just use default openssl.

    @scr-oath
    scr-oath committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    96dc440 View commit details
    Browse the repository at this point in the history

  2. Since file(...) is so trivial to use, changed the client cert, key, a… 

    …nd ca cert to be the data.

See also hashicorp/terraform-provider-http#211
    @scr-oath
    scr-oath committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ba0844a View commit details
    Browse the repository at this point in the history