Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateMgr must be able to return with locked state #28128

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Mar 17, 2021

The current usage of internal remote state backends requires that
StateMgr be able to return an instance of statemgr.Full even if the
state is currently locked.

Fixes #28100

@jbardin
Copy link
Member Author

jbardin commented Mar 17, 2021

=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackend
--- PASS: TestBackend (6.27s)
=== RUN   TestBackend_lockDisabled
--- PASS: TestBackend_lockDisabled (0.05s)
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClient
--- PASS: TestRemoteClient (0.06s)
=== RUN   TestEtcdv3_stateLock
--- PASS: TestEtcdv3_stateLock (2.11s)
=== RUN   TestEtcdv3_destroyLock
--- PASS: TestEtcdv3_destroyLock (0.07s)

@jasons42
Copy link
Contributor

@jbardin Sorry to bother you about this, but is there anyone else who could review this, and my changes in #28078 if @bmcustodio is not available?

@jbardin
Copy link
Member Author

jbardin commented Mar 31, 2021

Hi @jasons42,

Sorry about the delay here, @bmcustodio is the only contact listed in the CODEOWNERS for this package. I'm not sure how to go about getting another maintainer for the package, but I can check with @pkolyvas and see if there is anything we can do in the meantime.

@jasons42
Copy link
Contributor

jasons42 commented Jul 6, 2021

@jbardin Sorry to bug you again, but were you able to see if there are any options for getting this and my change to increase the max etcd message size? We've run into the max etcd message size in a couple places now and need to either get this fixed or migrate to a different backend.

As an aside, if the code owner is not around anymore, should the etcdv3 backend even be listed as supported in the documentation?

@jbardin
Copy link
Member Author

jbardin commented Jul 13, 2021

Hi @jasons42, sorry, the support status is a good question. I'll see what I can do about changing that status and merging outstanding PRs.

The current usage of internal remote state backends requires that
`StateMgr` be able to return an instance of `statemgr.Full` even if the
state is currently locked.
@jbardin jbardin requested review from a team and removed request for bmcustodio July 20, 2021 18:04
@jbardin jbardin merged commit 017633f into main Jul 20, 2021
@jbardin jbardin deleted the jbardin/etcdv3 branch July 20, 2021 18:28
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcdv3 backend acceptance tests fail due to locking issue
2 participants