Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hcl v2.7.2 #27055

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Upgrade to hcl v2.7.2 #27055

merged 1 commit into from
Nov 30, 2020

Conversation

alisdair
Copy link
Contributor

Fixes #27041, fixes #26746. Targeting backport to 0.14.0 because #27041 is a crash with sensitive values.

Upstream changelog:

Bugs Fixed

  • gohcl: Fix panic when decoding into type containing value slices. (#335)
  • hclsyntax: The unusual expression null[*] was previously always returning an unknown value, even though the rules for [*] normally call for it to return an empty tuple when applied to a null. As well as being a surprising result, it was particularly problematic because it violated the rule that a calling application may assume that an expression result will always be known unless the application itself introduces unknown values via the evaluation context. null[*] will now produce an empty tuple. (#416)
  • hclsyntax: Fix panic when traversing a list, tuple, or map with cty "marks" (#424)

@alisdair alisdair added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 30, 2020
@alisdair alisdair added this to the v0.14.0 milestone Nov 30, 2020
@alisdair alisdair requested a review from a team November 30, 2020 16:29
@alisdair alisdair self-assigned this Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #27055 (7256738) into master (111825d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 95.28% <0.00%> (-1.89%) ⬇️
terraform/eval_diff.go 66.51% <0.00%> (-0.92%) ⬇️
terraform/node_resource_apply_instance.go 75.00% <0.00%> (-0.79%) ⬇️
dag/walk.go 91.54% <0.00%> (-0.71%) ⬇️

@alisdair alisdair merged commit 5c7b03f into master Nov 30, 2020
@alisdair alisdair deleted the alisdair/hcl-v2.7.2 branch November 30, 2020 17:11
@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with sensitive string manipulation functions - v14 rc1 null[*] should be equivalent to []
2 participants