Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: fix ProviderConfigTransformer [v0.13 backport] #26567

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

mildwonkey
Copy link
Contributor

The ProviderConfigTransformer was using only the provider FQN to attach
a provider configuration to the provider, but what it needs to do is
find the local name for the given provider FQN (which may not match the
type name) and use that when searching for matching provider
configuration.

Fixes #26556

The ProviderConfigTransformer was using only the provider FQN to attach
a provider configuration to the provider, but what it needs to do is
find the local name for the given provider FQN (which may not match the
type name) and use that when searching for matching provider
configuration.

Fixes #26556

This will also be backported to the v0.13 branch.
@mildwonkey mildwonkey requested a review from a team October 13, 2020 13:26
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #26567 into v0.13 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/transform_provider.go 79.62% <100.00%> (+0.07%) ⬆️
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️
terraform/evaluate.go 51.05% <0.00%> (-0.47%) ⬇️
internal/providercache/dir.go 72.91% <0.00%> (+6.25%) ⬆️

@mildwonkey mildwonkey merged commit ca61e4e into v0.13 Oct 13, 2020
@mildwonkey mildwonkey deleted the mildwonkey/b-provider-config-backport branch October 13, 2020 14:07
@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants