data sources with indexed references to managed resources #26458
Conversation
If a data source refers to a indexed managed resource, we need to re-target that reference to the containing resource for planning. Since data sources use the same mechanism as depends_on for managed resource references, they can only refer to resources as a whole.
jbardin
force-pushed
the
jbardin/data-ref-index
branch
from
74b903e to
78322d5
Compare
Codecov Report
|
| resAddr = s | ||
| case addrs.ResourceInstance: | ||
| resAddr = s.Resource | ||
| r.Subject = resAddr |
There was a problem hiding this comment.
More a question: reading this movement from the previous block, this appears to be the addition that has changed things (changing the subject). What happened here? Reading the PR summary, I was looking for some change to reading ManagedResourceMode but that behavior hasn't changed (but please correct my reading!): you go from checking == for ManagedResourceMode to != and a continue ... so this behavior is the same as the earlier block.
There was a problem hiding this comment.
I think this is the relevant bit in the PR summary?
we need to re-target that reference to the containing resource for planning
But I'm also interested in this change from == to != ... is it doing anything I'm not seeing? (not saying to revert this part of the change, this continue might make things make more logical sense to future readers)
There was a problem hiding this comment.
Yes, the r.Subject = resAddr is the key change here. The problem was that when the reference was to an indexed resource instance, that wouldn't match up with the resource addresses used for depends_on when building the plan graph, since there are no individual instances at that point. This prevented the data source from being connected to the resource during planning, and allowing the data source to be read earlier than expected.
You correct that the resAddr.Mode != addrs.ManagedResourceMode logic didn't change. I believe I had some more code in here that made a difference during the refactor (and made it longer, instigating moving it to another method), but the append logic did end up being the same in the end.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
If a data source refers to a indexed managed resource instance, we need to
re-target that reference to the containing resource for planning. Since
data sources use the same mechanism as depends_on for managed resource
references, they can only refer to resources as a whole.