Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: Eval module call arguments for import #25890

Merged
merged 1 commit into from
Aug 19, 2020
Merged

terraform: Eval module call arguments for import #25890

merged 1 commit into from
Aug 19, 2020

Commits on Aug 17, 2020

  1. terraform: Eval module call arguments for import 

    Include the import walk in the list of operations for which we create an
EvalModuleCallArgument node. This causes module call arguments to be
evaluated even if the module variables have defaults, ensuring that
invalid default values (such as the common "{}" for variables thought of
as maps) do not cause failures specific to import.

This fixes a bug where a child module evaluates an input variable in its
locals block, assuming that it is a nested object structure. The bug
report includes a default value of "{}", which is overridden by a root
variable value. Without the eval node added in this commit, the default
value is used and the local evaluation errors.
    @alisdair
    alisdair committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    d8e9964 View commit details
    Browse the repository at this point in the history