Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/import: remove -provider command line argument #24090

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

mildwonkey
Copy link
Contributor

Now that #22862 has been merged, terraform will properly pick up the
resource provider configuration from state. We can therefore remove the deprecated
-provider flag.

Now that #22862 has been merged, terraform will properly pick up the
resource provider configuration from state. We can remove the deprecated
`-provider` flag.
@mildwonkey mildwonkey requested a review from a team February 12, 2020 19:08
@@ -156,36 +155,6 @@ func (c *ImportCommand) Run(args []string) int {
return 1
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me wants to keep the -provider argument definition above and make it generate a helpful error message below if it's non-empty. 🤔

With that said, I don't have a ready-to-go suggestion here for an actionable direction that error message could give. "Specify the provider in the configuration instead" is the gist of it, but I expect that most folks won't really know what to do about it.

So with all of that said, I think it'll be okay to just break this here and then we can describe the migration path in the changelog and/or upgrade guide where we'll have more "space" to describe what the resolution is and link to other relevant documentation.

@mildwonkey
Copy link
Contributor Author

Thanks!
ps: I had not meant to remove your label, I believe we were labeling at the same time 🤷‍♀

@mildwonkey mildwonkey merged commit 1c7167a into master Feb 12, 2020
@mildwonkey mildwonkey deleted the mildwonkey/import branch February 12, 2020 19:45
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants