plugin: Pass TerraformVersion from ConfigureRequest #22654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was reading through the code and trying to understand where does the testing framework get Terraform version from I found that there are two places which are sourcing version, one of which seems redundant.
terraform/terraform/eval_context_builtin.go
Lines 179 to 182 in 75d3f1e
I believe that this is just oversight and not a safeguard against callers of
GRPCProvider.Configure
which wouldn't declare Terraform version, but I'm happy to be corrected! 😄A side effect of this change is that we'll now report pre-released versions too, i.e. custom built
0.12.7
from master will be reported as0.12.7-dev
, rather than simple0.12.7
.