Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: Pass TerraformVersion from ConfigureRequest #22654

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Conversation

radeksimko
Copy link
Member

As I was reading through the code and trying to understand where does the testing framework get Terraform version from I found that there are two places which are sourcing version, one of which seems redundant.

req := providers.ConfigureRequest{
TerraformVersion: version.String(),
Config: cfg,
}

I believe that this is just oversight and not a safeguard against callers of GRPCProvider.Configure which wouldn't declare Terraform version, but I'm happy to be corrected! 😄

A side effect of this change is that we'll now report pre-released versions too, i.e. custom built 0.12.7 from master will be reported as 0.12.7-dev, rather than simple 0.12.7.

@radeksimko radeksimko merged commit c4e508f into master Aug 31, 2019
@radeksimko radeksimko deleted the plugin-pass branch August 31, 2019 06:20
@appilon appilon added the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Sep 6, 2019
@appilon appilon removed the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Sep 13, 2019
@ghost
Copy link

ghost commented Oct 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants