Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for nested fields with checkKey on ResourceDiffs. #18795

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Allow for nested fields with checkKey on ResourceDiffs. #18795

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ee4339
Allow for nested fields with checkKey on ResourceDiffs.
paddycarver Sep 6, 2018
393c326
Add tests to ensure clearing sub-blocks works.
paddycarver Sep 20, 2018
2eadc8f
Don't allow sub-blocks for SetNew.
paddycarver Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions helper/schema/resource_diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,11 +536,15 @@ func childAddrOf(child, parent string) bool {

// checkKey checks the key to make sure it exists and is computed.
func (d *ResourceDiff) checkKey(key, caller string) error {
s, ok := d.schema[key]
if !ok {
keyParts := strings.Split(key, ".")
var schema *Schema
schemaL := addrToSchema(keyParts, d.schema)
if len(schemaL) > 0 {
schema = schemaL[len(schemaL)-1]
} else {
return fmt.Errorf("%s: invalid key: %s", caller, key)
}
if !s.Computed {
if !schema.Computed {
return fmt.Errorf("%s only operates on computed keys - %s is not one", caller, key)
}
return nil
Expand Down