add instance tag support #173
Conversation
|
This is related to #28 as well. |
|
I implemented a concept mentioned in #87, where I'm sorting the tags to ensure a consistent order after |
|
This is also dependent on mitchellh/goamz#79 now, as I had to add a |
add update functionality, ensure canonical ordering document instance tags use base tag functions in aws_instance
|
I rebased and squashed some stuff to make this easier to merge, and to make it easier to merge it separately from any other taggable things that I'll be PR'ing soon. |
|
I am using in conjunction with #175 this works pretty good, updates tags some times but that is not offensive. Tags make terraform usable for me, great work |
|
👍 |
|
Awesome! So, this is still waiting on mitchellh/goamz#79. Also, @mitchellh is working on improvements to handle the ordering of sets. This will allow us to skip the alphabetical solution and let the user specify any order. I would say we should probably wait and adapt for that. I'll let Mitchell describe how to do that once it's implemented. |
|
Ditto as this comment, same situation. Tags are still very important! |
ghost
locked and limited conversation to collaborators
This relies on mitchellh/goamz#77 and adds the ability to tag instances. I haven't gotten the update part happening yet, but I figured I'd PR this anyway as it's useful as-is.