-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped the Terraform provider AWS vendoring #16661
Bumped the Terraform provider AWS vendoring #16661
Conversation
4fbd905
to
6d587f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ninir! This looks good to me.
I'm going to hold on merging it until after 0.11.0 final because we're currently in the code freeze period for the release (critical bugfixes only).
I am not able to build this. This might be a mistake on my side, but the current master works for me.
I am sorry, if this is unrelated. Edit It is just a go fmt error. I am able to compile this with a plain this PR
master
|
@Ninir @apparentlymart Terraform 0.11.0 has been released for some time now, in fact I see 0.11.1 has been released more recently, yet this PR still hasn't been merged. Can we get this released ASAP? I'd really like to not have to keep building a custom fork of Terraform ;-) (without this change profiles can't be used for accessing S3 based remote state) |
We waited until the 0.11.1 release before making most changes because we wanted to leave things clear for any urgent bugfixes we might need to release, but we're now back to normal merging. Thanks again for submitting this, @Ninir! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Since the merge of hashicorp/terraform-provider-aws#1608, AWS is now able to assume role from a given profile defined in
~/.aws/credentials
, as in:This bumps the
terraform-provider-aws
dependency so that everything relying on AWS (e.g. S3 backend) also reads it properly.It also updates the AWS Go SDK to 1.12.27 in order to match the related dependencies from
terraform-provider-aws
Used commands:
govendor fetch github.com/terraform-providers/terraform-provider-aws/aws
govendor fetch github.com/aws/aws-sdk-go/...@=v1.12.27
As a sidenote, should I also send a similar PR to https://github.com/terraform-providers/terraform-provider-terraform waiting for 0.11 to be released?