Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

govendor fetch github.com/hashicorp/go-plugin/... #15788

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

apparentlymart
Copy link
Contributor

This puts us on a version that has grpc protocol support. Although we're not actually using that yet, the plugin has handshake changed slightly to allow plugins to declare whether they use the old or new protocols, and so this upgrade allows us to support plugins that were built against newer versions of go-plugin that include this extra field in the handshake.

This fixes #15756.

@jbardin
Copy link
Member

jbardin commented Aug 11, 2017

The grpc vendor versions are out of sync. I think you need to refresh the whole google.golang.org/grpc vendor tree.

@apparentlymart
Copy link
Contributor Author

Heh sorry was working on that in my terminal... should've said not to review it yet. Hopefully this new commit fixes it. 😀

@apparentlymart
Copy link
Contributor Author

Hmm looks like I now have a test failure that I didn't get locally. Will poke some more!

This puts us on a version that has grpc protocol support. Although we're
not actually using that yet, the plugin has handshake changed slightly to
allow plugins to declare whether they use the old or new protocols, and
so this upgrade allows us to support plugins that were built against
newer versions of go-plugin that include this extra field in the
handshake.

This fixes #15756.
@apparentlymart
Copy link
Contributor Author

Looks like we were lagging on the experimental http2 library too, and grpc uses that at this time. So this now upgrades:

  • go-plugin
  • google.golang.org/grpc
  • golang.org/x/net/http2

@apparentlymart
Copy link
Contributor Author

Ooookay... @jbardin, this seems to actually be ready now!

@apparentlymart apparentlymart merged commit ee5fc3b into master Aug 11, 2017
@apparentlymart apparentlymart deleted the upgrade-go-plugin branch February 5, 2018 19:18
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.10.0: "terraform init" works, but "terraform plan" fails with "netrpc: connect: no such file or directory"
2 participants