Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add AWS SES dkim resource #14831

Closed
wants to merge 1 commit into from

Conversation

arr-dev
Copy link

@arr-dev arr-dev commented May 25, 2017

Added aws_ses_dkim resource, according to http://docs.aws.amazon.com/ses/latest/DeveloperGuide/easy-dkim-dns-records.html

Would like some feedback on schema, not sure if there is anything else needed here.

Haven't ran integration test since I'am having issues with my personal AWS account,
but hope to enable it soon so I can test this, hopefully having some feedback before that.

@leonsmith
Copy link

Do you think its wise to change the count = 3 in the example docs to be "${length(aws_ses_domain_dkim.example.dkim_tokens)}" ?

I imagine it will be copied out of the docs verbatim so thats a bit more future proof incase the the number of dkim tokens changes?

@arr-dev
Copy link
Author

arr-dev commented Jun 22, 2017

I actually tried that and Terraform reported that count can't be interpolated or something like that.
It was strange to me to.

I should probably close this PR and reopen it on https://github.com/terraform-providers/terraform-provider-aws?

@handlerbot
Copy link
Contributor

I'd love to get this into Terraform, this is one of the last manual Route 53 editing operations we have to do for our turnups. :-D

@apparentlymart @radeksimko This looks ~ready to go after fixing the (what should be trivial) conflicts in provider.go and aws.erb, can this be uplifted to terraform-provider-aws?

If not, @arr-dev, do you have time to recreate the PR there, or should I do it, while giving you all credit for the code?

@arr-dev
Copy link
Author

arr-dev commented Sep 30, 2017

@handlerbot I'll submit a PR tomorrow or monday the latest. Thanks for reminding me of this

@arr-dev
Copy link
Author

arr-dev commented Oct 2, 2017

Recreated at hashicorp/terraform-provider-aws#1786

@arr-dev arr-dev closed this Oct 2, 2017
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants