provider/vsphere Set different hostname of a VM than name

[ewypych]

Fixes: #14659

With this version, one can set different hostname (during the OS customization) than a VM name. If "hostname" variable isn't set, the "name" will be used in the customization process. "Hostname" is optional.

Tested on my vSphere Lab (both scenarios), everything works as expected. Of course, there is another acc test created. Output:

$ make testacc TEST=./builtin/providers/vsphere/ TESTARGS='-run=TestAccVSphereVirtualMachine_hostname'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/23 20:31:14 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/vsphere/ -v -run=TestAccVSphereVirtualMachine_hostname -timeout 120m
=== RUN   TestAccVSphereVirtualMachine_hostname
2017/05/23 20:31:25 [DEBUG] template=
resource "vsphere_virtual_machine" "foo" {
    name = "terraform-test"
    hostname = "testterraform"

%s
    vcpu = 2
    memory = 1024
    network_interface {
        label = "%s"
        ipv4_address = "%s"
        ipv4_prefix_length = %s
        ipv4_gateway = "%s"
    }
     disk {
%s
        template = "%s"
        iops = 500
    }

}
--- PASS: TestAccVSphereVirtualMachine_hostname (376.23s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/vsphere        376.254s

Please review and tell me if it's anything more I should do.

[ewypych]

Hello!
Could someone update me with this PR? :)

[ewypych]

Migrated to terraform-providers/terraform-provider-vsphere#79

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.