Add ability to import Google Compute persistent disks

[bashtoni]

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeDisk_importBasic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/17 14:44:27 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeDisk_importBasic -timeout 120m
=== RUN   TestAccComputeDisk_importBasic
--- PASS: TestAccComputeDisk_importBasic (26.42s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	26.434s

[radeksimko]

Thank you for the PR and sorry for a small delay in reviewing it.

The tests are passing, I just left you 2 comments, but overall this looks good.

If you can also resolve conflicts that would be helpful. 😃

[radeksimko]

Is there any specific reason we cannot use err here for clarity?

[radeksimko]

It may sound like nitpick and it may be just me, but I spent good couple of minutes trying to understand what all these changes above (with strings.Split) mean.
So just for clarity/readability I think it would help if we renamed zoneUrl to zoneUrlParts, typeUrl to typeUrlParts etc. so that it's more obvious that these variables hold slice, not a string?

[bashtoni]

@radeksimko Reworded as suggested, fixed conflicts.

Thanks for reviewing!

[radeksimko]

@bashtoni Thanks for making those changes, would you mind changing the last two variables too? i.e. imageUrl and snapshotUrl. Then I'm happy to click the big green button and 🚢 it 😃

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.