Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_appengine_app resource #14293

Closed
wants to merge 3 commits into from

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented May 8, 2017

This adds a resource google_appengine_app to enable Google App Engine on a project. My major intent for this is to be able to enable Google Datastore which requires App Engine to be enabled.

Would be used like this:

provider "google" {
  project = "my-testing-project-123"
  region  = "europe-west1"
}

resource "google_appengine_app" "default" {
  project = "my-testing-project-123"
  region  = "europe-west"
}

The current implementation works for me but so far it is still very bare-bones since I would love to get your feedback on this first before continuing (e.g. with writing proper tests and more docs).

The strange thing about Google App Engine is that it can only be activated once for a gcloud project but cannot be de-activated: During activation one has to choose a region (which as a side-effect also determines the data-locality of the Google Datastore instance of that gcloud project) and this cannot be changed afterwards.

How would I best formulate these conditions in terms of terraform? E.g. terraform requires me to implement the Delete method but I don't see any sensible "delete" operation for Google App Engine.

@danawillow @paddycarver @radeksimko thoughts?

@paddycarver
Copy link
Contributor

Hi @ctavan! I want to take a close look at this, because it's confusing at first glance. But I need to play with the API a bit to understand if there's a better way to do this, or if we're just accurately representing a confusing API. Unfortunately, I doubt I'll have time this week or next. Unless @radeksimko or @danawillow have the bandwidth to look into this, I don't see it getting attention prior to 5/23, at the earliest. I just wanted to be up front about that, because I think it's a great addition to Terraform and has been on my list for a while, but I think it also deserves a thorough review. I didn't want you to hear nothing and get discouraged or think you were being ignored. It's definitely on my radar, I just can't block off the time it deserves at the moment.

Thanks for the PR! Really appreciate all the work that went into this.

@ctavan
Copy link
Contributor Author

ctavan commented May 11, 2017

@paddycarver no worries and thanks for the response!

Just to let you know: I'm currently using this with my patched version of terraform to enable Datastore for a production project and it works really well for me.

That of course doesn't mean that there might not be a better way to achieve activation of Datastore so I'd be really happy about a thorough review.

@ctavan
Copy link
Contributor Author

ctavan commented Jun 14, 2017

Moved over to hashicorp/terraform-provider-google#125

@ctavan ctavan closed this Jun 14, 2017
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants