provider/aws Add S3 bucket object tag support

[ewbankkit]

Add support for AWS S3 object tagging.

[ewbankkit]

Rebased and fixed some acceptance tests.

[stack72]

Hi @ewbankkit

How is this progressing? Ready for a review?

Thanks

Paul

[ewbankkit]

Right now the acceptance tests are passing and the functionality works but Update is always recreating - via PUT - the whole bucket object even if just the tags change. This is true for the bucket object ACL changes also.
I'd like to correct that.

[ewbankkit]

I'd certainly welcome any preliminary comments.

[ewbankkit]

Because of the way the source attribute on the resource works - the value of source may not change but the contents of the file referred to may - we will have to always rewrite the bucket object whenever any change is detected.

[ewbankkit]

Rebased.
Removing WIP.
Ready for review.

[stack72]

LGTM Thanks for this work :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=S3BucketObject'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/13 16:45:28 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=S3BucketObject -timeout 120m
=== RUN   TestAccDataSourceAWSS3BucketObject_basic
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (98.21s)
=== RUN   TestAccDataSourceAWSS3BucketObject_readableBody
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (95.32s)
=== RUN   TestAccDataSourceAWSS3BucketObject_kmsEncrypted
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (126.91s)
=== RUN   TestAccDataSourceAWSS3BucketObject_allParams
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (102.44s)
=== RUN   TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_source (61.92s)
=== RUN   TestAccAWSS3BucketObject_content
--- PASS: TestAccAWSS3BucketObject_content (61.63s)
=== RUN   TestAccAWSS3BucketObject_withContentCharacteristics
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (59.16s)
=== RUN   TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_updates (104.26s)
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioning
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (105.96s)
=== RUN   TestAccAWSS3BucketObject_kms
--- PASS: TestAccAWSS3BucketObject_kms (91.82s)
=== RUN   TestAccAWSS3BucketObject_sse
--- PASS: TestAccAWSS3BucketObject_sse (67.96s)
=== RUN   TestAccAWSS3BucketObject_acl
--- PASS: TestAccAWSS3BucketObject_acl (108.00s)
=== RUN   TestResourceAWSS3BucketObjectAcl_validation
--- PASS: TestResourceAWSS3BucketObjectAcl_validation (0.00s)
=== RUN   TestAccAWSS3BucketObject_storageClass
--- PASS: TestAccAWSS3BucketObject_storageClass (108.61s)
=== RUN   TestResourceAWSS3BucketObjectStorageClass_validation
--- PASS: TestResourceAWSS3BucketObjectStorageClass_validation (0.00s)
=== RUN   TestAccAWSS3BucketObject_tags
--- PASS: TestAccAWSS3BucketObject_tags (62.80s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	1255.034s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.