Add 'explicit configuration required' message when provider schema validation fails #34595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
ValidateProviderConfig
RPC fails as part of schema validation for a generated provider configuration block, we add an additional sourceless diagnostic that adds some context around the provider that failed saying the user should add an explicit configuration block.We do not currently do this if the schema validation itself fails (such as missing a required attribute). This PR adds the same error message we generate for the failed provider validation call to the earlier schema validation. The logic is exactly the same: if a generated configuration block fails validation it means the user must write it themselves.
Fixes #34594
Fixes #28482
Target Release
1.7.2
Draft CHANGELOG entry
ENHANCEMENTS