Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: Fix createEmptyBlocks NestingSingle bug #26028

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

alisdair
Copy link
Contributor

When calling createEmptyBlocks, we only intend to process legacy SDK blocks (NestingList or NestingSet), but the function also needs to pass through NestingSingle block types untouched. To do so we must only look up the container's element type after we've established that the block is backed by a container.

Fixes #26011

When calling createEmptyBlocks, we only intend to process legacy SDK
blocks (NestingList or NestingSet), but the function also needs to pass
through NestingSingle block types untouched. To do so we must only look
up the container's element type after we've established that the block
is backed by a container.
@alisdair alisdair requested a review from a team August 28, 2020 00:36
@alisdair alisdair self-assigned this Aug 28, 2020
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo, sneaky

@sdebruyn
Copy link

The impact of this one seems quite large, please release 0.13.2 as soon as possible

@m2b-arariba
Copy link

I'm with the same problem.

That's my terraform version

Terraform v0.13.1
+ provider registry.terraform.io/-/azurerm v2.25.0
+ provider registry.terraform.io/hashicorp/azurerm v2.25.0

@sennerholm
Copy link

0.13.2 seems to be released now,

@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: not a collection type (regression between 13.1 and 13.0)
5 participants