Use more recent version of govmomi

[caseyaedwards]

Terraform Version

Terraform v0.9.3-dev

Affected Resource(s)

• vsphere_virtual_machine

Expected Behavior

vSphere provider works and creates a VM that has a network adapter which has a label with a slash in the name.

Actual Behavior

Fails saying unable to find network since the version of govmomi being used splits across forward slashes and only returns the last section. This means if you have a network label with a slash in it such as IP/CIDR, it will only return the CIDR.

Steps to Reproduce

It's easiest to use govc directly since it will produce the same outcome as Terraform. Here's an example between working and nonworking versions.

govc version
govc 0.13.0
govc vm.network.change -net "v123 4.5.6.7/28" -vm "somevm.domain.com" ethernet-0
govc: network 'v123 4.5.6.7/28' not found

govc version
govc 0.14.0
govc vm.network.change -net "v123 4.5.6.7/28" -vm "somevm.domain.com" ethernet-0
(no output, completed successfully)

Important Factoids

Using slashes in network labels

References

• vSphere network label inconsistency with VDS in vCenter folder #8584 (May be related, not 100% sure)
• Cannot assign network containing a slash in its name vmware/govmomi#592

[Defilan]

I am seeing this exact same issue with our vSphere 6.5 environment. We have network labels that have a "/" in the name, and it won't work with the included version of govc.

Thanks for posting this, caseyaedwards!

[madrover]

I believe I've found the same issue with folders.
I'll try to upgrade the library to the latest and create a PR

[caseyaedwards]

Sorry, I think I made a mistake. I patched govmomi myself with a crappy fix; regex matching the way we name our vswitches: #.#.#.#/## (basically ipaddr / cidr) and then manually piecing it back together if it matches. Then I forgot that I did that and rebuilt govc/terraform thinking that it was fixed because I was building off of govmomi 0.14. I will upload my patched version of govmomi. I believe this will fix your issue @Defilan although you may need to adjust the regex slightly to match your vswitch naming scheme. I don't think it will fix your issue though @madrover since the regex needs to be specific enough to not match anything except the final object.

From looking at the govmomi source I don't think there's an easy way to fix this since it does a simple path.split or a strings.split on '/'. I don't know Go very well though so I'm hoping I'm wrong and that there's an easy way to fix it. I'll look into opening a more detailed ticket in the govmomi repo with my findings.

[caseyaedwards]

Not super happy with this fix but it works for us:
https://github.com/caseyaedwards/govmomi/commit/6b1622582ba798e1cb834937b41de73b93f049f7

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.