Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more recent version of govmomi #85

Closed
hashibot opened this issue Jun 13, 2017 · 3 comments
Closed

Use more recent version of govmomi #85

hashibot opened this issue Jun 13, 2017 · 3 comments
Labels
bug Type: Bug

Comments

@hashibot
Copy link

This issue was originally opened by @caseyaedwards as hashicorp/terraform#13366. It was migrated here as part of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.9.3-dev

Affected Resource(s)

  • vsphere_virtual_machine

Expected Behavior

vSphere provider works and creates a VM that has a network adapter which has a label with a slash in the name.

Actual Behavior

Fails saying unable to find network since the version of govmomi being used splits across forward slashes and only returns the last section. This means if you have a network label with a slash in it such as IP/CIDR, it will only return the CIDR.

Steps to Reproduce

It's easiest to use govc directly since it will produce the same outcome as Terraform. Here's an example between working and nonworking versions.

govc version
govc 0.13.0
govc vm.network.change -net "v123 4.5.6.7/28" -vm "somevm.domain.com" ethernet-0
govc: network 'v123 4.5.6.7/28' not found

govc version
govc 0.14.0
govc vm.network.change -net "v123 4.5.6.7/28" -vm "somevm.domain.com" ethernet-0
(no output, completed successfully)

Important Factoids

Using slashes in network labels

References

@hashibot hashibot added the bug Type: Bug label Jun 13, 2017
@mjrider
Copy link
Contributor

mjrider commented Aug 16, 2017

@caseyaedwards is this fixed now #114 (update govmomi to 0.15) has been merged?

@caseyaedwards
Copy link

I believe so, as long as this comit made it into 0.15.

I was incorrect about it being fixed in 0.14 as I had fixed the issue myself using a bad workaround and forgot that I had fixed it myself.

I'll test when I get some time to confirm 100%.

@vancluever
Copy link
Contributor

Hey all, this is an outdated issue since a few versions back (pretty much v0.2.0), so I'm going to close it now. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants