Skip to content

Commit

Permalink
description is now a required field for google_dns_managed_zone
Browse files Browse the repository at this point in the history
The description field for a managed-zone is now a required field when using the Cloud API.
This commit defaults the field to use the text "Managed by Terraform" to minimize required boilerplate for Terraform users.

Ref: https://cloud.google.com/sdk/gcloud/reference/dns/managed-zones/create
  • Loading branch information
shaneog committed Mar 2, 2016
1 parent 834bfcd commit b03fc1d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions builtin/providers/google/resource_dns_managed_zone.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func resourceDnsManagedZone() *schema.Resource {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Default: "Managed by Terraform",
},

"name_servers": &schema.Schema{
Expand Down
1 change: 0 additions & 1 deletion builtin/providers/google/resource_dns_managed_zone_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,4 @@ var testAccDnsManagedZone_basic = fmt.Sprintf(`
resource "google_dns_managed_zone" "foobar" {
name = "mzone-test-%s"
dns_name = "terraform.test."
description = "Test Description"
}`, acctest.RandString(10))
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ The following arguments are supported:

* `dns_name` - (Required) The DNS name of this zone, e.g. "terraform.io".

* `description` - (Optional) A textual description field.
* `description` - (Optional) A textual description field. Defaults to 'Managed by Terraform'.

## Attributes Reference

Expand Down

0 comments on commit b03fc1d

Please sign in to comment.