Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
provider/aws: fix db_subnet acc test
AWS accepts uppercase DB Subnet Group names - it just automatically downcases them. We already had logic to handle that - so we intentionally had an acctest with uppercase characters that was now failing. Loosening the regexp to allow uppercase letters for now - we can discuss if we want to tighten the validation as a separate question. /cc @radeksimko @catsby
- Loading branch information
8fa96d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally 👍 for tightening the validation, that was basically one of the original reasons. I think that making things lowercase under the hood just hides that problem away. User should be aware of what's happening - i.e. the definition in DSL should be IMO as close to reality as possible with as little magic in the middle as possible.
8fa96d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radeksimko yeah I was just in "fix the tests" mode - I'd be okay with that. We'd just need to clean up the extra code for the downcase comparison as well.
8fa96d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phinze Understood. If tighten, then properly 😃