Skip to content

Commit

Permalink
provider/aws: RDS Read Replica cleanups
Browse files Browse the repository at this point in the history
remove typos, debugging, and try spelling things correctly
  • Loading branch information
catsby committed May 21, 2015
1 parent 6b6aa86 commit 6de8f9d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
7 changes: 0 additions & 7 deletions builtin/providers/aws/resource_aws_db_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -445,11 +445,6 @@ func resourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("[DEBUG] Error setting replicas attribute: %#v, error: %#v", replicas, err)
}

if v.ReadReplicaSourceDBInstanceIdentifier != nil {
log.Printf("\n\n------\nread replica instance identifier: %#v", *v.ReadReplicaSourceDBInstanceIdentifier)
} else {
log.Printf("\n\n------\nno replica identifier")
}
d.Set("replicate_source_db", v.ReadReplicaSourceDBInstanceIdentifier)

return nil
Expand Down Expand Up @@ -493,7 +488,6 @@ func resourceAwsDbInstanceDelete(d *schema.ResourceData, meta interface{}) error
}

func resourceAwsDbInstanceUpdate(d *schema.ResourceData, meta interface{}) error {
log.Printf("\n\n-------- ENTER UPDATE -------\n\n")
conn := meta.(*AWSClient).rdsconn

d.Partial(true)
Expand Down Expand Up @@ -622,7 +616,6 @@ func resourceAwsDbInstanceUpdate(d *schema.ResourceData, meta interface{}) error
}
}
d.Partial(false)
log.Printf("\n\n-------- EXIT UPDATE -------\n\n")
return resourceAwsDbInstanceRead(d, meta)
}

Expand Down
2 changes: 1 addition & 1 deletion builtin/providers/aws/resource_aws_db_instance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func testAccReplicaInstanceConfig(val int) string {
resource "aws_db_instance" "replica" {
identifier = "tf-replica-db-%d"
backup_retention_period = 0
replicate_source_db = "${aws_db_instance.bar.identifier}"
replicate_source_db = "${aws_db_instance.bar.identifier}"
allocated_storage = "${aws_db_instance.bar.allocated_storage}"
engine = "${aws_db_instance.bar.engine}"
engine_version = "${aws_db_instance.bar.engine_version}"
Expand Down
4 changes: 2 additions & 2 deletions website/source/docs/providers/aws/r/db_instance.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ The following arguments are supported:
* `username` - (Required) Username for the master DB user.
* `availability_zone` - (Optional) The AZ for the RDS instance.
* `backup_retention_period` - (Optional) The days to retain backups for. Must be
`1` or greater to be a source for a [Read Replicate][1].
`1` or greater to be a source for a [Read Replica][1].
* `backup_window` - (Optional) The backup window.
* `iops` - (Optional) The amount of provisioned IOPS. Setting this implies a
storage_type of "io1".
Expand All @@ -74,7 +74,7 @@ database, and to use this value as the source database. This correlates to the
more information on using Replication.


~> **NOTE:** Removing the `relicate_source` attribute from an existing RDS
~> **NOTE:** Removing the `replicate_source` attribute from an existing RDS
Replicate database managed by Terraform will promote the database to a fully
standalone database.

Expand Down

0 comments on commit 6de8f9d

Please sign in to comment.