Merge pull request #3777 from hashicorp/pr-3751

provider/aws: fix panic with SNS topic policy if omitted
hashicorp · Nov 10, 2015 · 68764e6 · 68764e6
2 parents 22f0f5f + 15533dc
commit 68764e6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/builtin/providers/aws/resource_aws_sns_topic.go b/builtin/providers/aws/resource_aws_sns_topic.go
@@ -44,10 +44,13 @@ func resourceAwsSnsTopic() *schema.Resource {
 			"policy": &schema.Schema{
 				Type:     schema.TypeString,
 				Optional: true,
-				ForceNew: false,
 				Computed: true,
 				StateFunc: func(v interface{}) string {
-					jsonb := []byte(v.(string))
+					s, ok := v.(string)
+					if !ok || s == "" {
+						return ""
+					}
+					jsonb := []byte(s)
 					buffer := new(bytes.Buffer)
 					if err := json.Compact(buffer, jsonb); err != nil {
 						log.Printf("[WARN] Error compacting JSON for Policy in SNS Topic")