Skip to content

Commit

Permalink
stacks: add test case without refresh only mode
Browse files Browse the repository at this point in the history
  • Loading branch information
@DanielMSchmidt
DanielMSchmidt committed Apr 2, 2024
1 parent a64d57c commit 2bd4017
Showing 1 changed file with 79 additions and 4 deletions.
83 changes: 79 additions & 4 deletions internal/terraform/context_apply_deferred_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ output "c" {
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),
"<unknown>": cty.ObjectVal(map[string]cty.Value{
"name": cty.UnknownVal(cty.String).Refine().
Expand All @@ -132,10 +133,12 @@ output "c" {
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"c": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("c"),
"upstream_names": cty.UnknownVal(cty.Set(cty.String)).RefineNotNull(),
"defer_read": cty.NullVal(cty.Bool),
}),
},
wantActions: map[string]plans.Action{
Expand All @@ -147,12 +150,14 @@ output "c" {
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),
},
wantOutputs: map[string]cty.Value{
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),

// FIXME: The system is currently producing incorrect
Expand Down Expand Up @@ -207,19 +212,22 @@ output "c" {
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),
// test.b is now planned for real, once for each instance
"b:1": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:1"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"b:2": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:2"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
// test.c gets re-planned, so we can finalize its values
// based on the new results from test.b.
Expand All @@ -230,6 +238,7 @@ output "c" {
cty.StringVal("b:1"),
cty.StringVal("b:2"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
},
wantActions: map[string]plans.Action{
Expand All @@ -249,12 +258,14 @@ output "c" {
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"b:2": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:2"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"c": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("c"),
Expand All @@ -263,6 +274,7 @@ output "c" {
cty.StringVal("b:1"),
cty.StringVal("b:2"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
},
wantOutputs: map[string]cty.Value{
Expand All @@ -271,19 +283,22 @@ output "c" {
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),
"b": cty.ObjectVal(map[string]cty.Value{
"1": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:1"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"2": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:2"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
}),
"c": cty.ObjectVal(map[string]cty.Value{
Expand All @@ -293,6 +308,7 @@ output "c" {
cty.StringVal("b:1"),
cty.StringVal("b:2"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
},
complete: true,
Expand All @@ -309,18 +325,21 @@ output "c" {
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.NullVal(cty.Bool),
}),
"b:1": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:1"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"b:2": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("b:2"),
"upstream_names": cty.SetVal([]cty.Value{
cty.StringVal("a"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
"c": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("c"),
Expand All @@ -329,6 +348,7 @@ output "c" {
cty.StringVal("b:1"),
cty.StringVal("b:2"),
}),
"defer_read": cty.NullVal(cty.Bool),
}),
},
wantActions: map[string]plans.Action{
Expand Down Expand Up @@ -356,8 +376,13 @@ terraform {
experiments = [unknown_instances]
}
variable "defer_read" {
type = bool
}
resource "test" "a" {
name = "deferred_read"
name = "a"
defer_read = var.defer_read
}
output "a" {
Expand All @@ -366,11 +391,44 @@ output "a" {
`,
},
stages: []deferredActionsTestStage{
{
inputs: map[string]cty.Value{
"defer_read": cty.False,
},
wantPlanned: map[string]cty.Value{
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"defer_read": cty.False,
"upstream_names": cty.NullVal(cty.Set(cty.String)),
}),
},

wantActions: map[string]plans.Action{
`test.a`: plans.Create,
},
wantApplied: map[string]cty.Value{
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"defer_read": cty.False,
"upstream_names": cty.NullVal(cty.Set(cty.String)),
}),
},
wantOutputs: map[string]cty.Value{
"a": cty.ObjectVal(map[string]cty.Value{
"name": cty.StringVal("a"),
"upstream_names": cty.NullVal(cty.Set(cty.String)),
"defer_read": cty.False,
}),
},
complete: true,
},
{
buildOpts: func(opts *PlanOpts) {
opts.Mode = plans.RefreshOnlyMode
},
inputs: map[string]cty.Value{},
inputs: map[string]cty.Value{
"defer_read": cty.True,
},
wantPlanned: map[string]cty.Value{
// The all resources will be deferred, so shouldn't
// have any action at this stage.
Expand All @@ -387,7 +445,20 @@ output "a" {
"upstream_names": cty.NullVal(cty.Set(cty.String)),
}),
},
complete: true,
complete: false,
},
{
inputs: map[string]cty.Value{
"defer_read": cty.True,
},
wantPlanned: map[string]cty.Value{
"a": cty.UnknownAsNull(cty.DynamicVal),
},

wantActions: map[string]plans.Action{},
wantApplied: map[string]cty.Value{},
wantOutputs: map[string]cty.Value{},
complete: false,
},
},
}
Expand Down Expand Up @@ -556,13 +627,17 @@ func (provider *deferredActionsProvider) Provider() providers.Interface {
Type: cty.Set(cty.String),
Optional: true,
},
"defer_read": {
Type: cty.Bool,
Optional: true,
},
},
},
},
},
},
ReadResourceFn: func(req providers.ReadResourceRequest) providers.ReadResourceResponse {
if key := req.PriorState.GetAttr("name"); key.IsKnown() && key.AsString() == "deferred_read" {
if key := req.PriorState.GetAttr("defer_read"); key.IsKnown() && key.True() {
return providers.ReadResourceResponse{
NewState: req.PriorState,
Deferred: &providers.Deferred{
Expand Down

0 comments on commit 2bd4017

Please sign in to comment.