Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vNic resources #876

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Support for vNic resources #876

merged 3 commits into from
Nov 4, 2019

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Oct 21, 2019

This resource manages vmk interfaces on ESXi hosts. Using a
combination of this resource and vsphere_host a terraform user can
setup a cluster of esx hosts and configure vmotion on them.

@ghost ghost added the size/xl Relative Sizing: Extra-Large label Oct 21, 2019
@ghost ghost added size/xxl Relative Sizing: Extra-Extra-Large documentation Type: Documentation and removed size/xl Relative Sizing: Extra-Large labels Oct 22, 2019
@koikonom koikonom changed the title vnic initial commit Support for vNic resources Oct 22, 2019
@koikonom koikonom marked this pull request as ready for review October 22, 2019 14:38
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but looks good overall!


func vNicSchema() map[string]*schema.Schema {
base := BaseVMKernelSchema()
base["host"] = &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is host separate from the rest of the schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the rest of the schema can be reused if we decide to include vnic as a block within a vsphere_host resource.

vsphere/resource_vsphere_vnic.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vnic.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vnic.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_vnic.go Show resolved Hide resolved
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kyriakos Oikonomakos added 3 commits November 4, 2019 16:31
This resource manages `vmk` interfaces on ESXi hosts. Using a
combination of this resource and `vsphere_host` a terraform user can
setup a cluster of esx hosts and configure vmotion on them.
@koikonom
Copy link
Contributor Author

koikonom commented Nov 4, 2019

(pushed a rebased branch, since github could not rebase on its own due to conflicts)

@koikonom koikonom merged commit 5477421 into master Nov 4, 2019
@koikonom koikonom deleted the f-resource-vnic branch November 4, 2019 17:10
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Type: Documentation size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants