-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for vNic resources #876
Conversation
466eed5
to
9053c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions, but looks good overall!
|
||
func vNicSchema() map[string]*schema.Schema { | ||
base := BaseVMKernelSchema() | ||
base["host"] = &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is host
separate from the rest of the schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the rest of the schema can be reused if we decide to include vnic as a block within a vsphere_host resource.
df0ad51
to
87087e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This resource manages `vmk` interfaces on ESXi hosts. Using a combination of this resource and `vsphere_host` a terraform user can setup a cluster of esx hosts and configure vmotion on them.
aff4d03
to
7774c82
Compare
(pushed a rebased branch, since github could not rebase on its own due to conflicts) |
This resource manages
vmk
interfaces on ESXi hosts. Using acombination of this resource and
vsphere_host
a terraform user cansetup a cluster of esx hosts and configure vmotion on them.