Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: r/vsphere_virtual_machine updated disks info #2272

Merged

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Oct 2, 2024

Description

resource/vsphere_virtual_machine: Updates to fix examples of disk0 to reflect that during import the disk get set back to default like Hard Disk 1.

References

Closes #2199

@github-actions github-actions bot added documentation Type: Documentation needs-review Status: Pull Request Needs Review labels Oct 2, 2024
@burnsjared0415 burnsjared0415 force-pushed the docs/vsphere_virtual_machine-disk branch from 4d0a06b to 6067f56 Compare October 2, 2024 16:39
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion.

@burnsjared0415 burnsjared0415 self-assigned this Oct 2, 2024
@burnsjared0415 burnsjared0415 added this to the v2.9.3 milestone Oct 2, 2024
@burnsjared0415 burnsjared0415 changed the title docs: vsphere_virtual_machine updated disks info docs: r/vsphere_virtual_machine updated disks info Oct 2, 2024
@burnsjared0415 burnsjared0415 force-pushed the docs/vsphere_virtual_machine-disk branch from 6067f56 to fec006f Compare October 2, 2024 17:11
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam marked this pull request as ready for review October 2, 2024 17:44
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 2, 2024 17:44
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 2, 2024
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Oct 2, 2024
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 2, 2024
@tenthirtyam tenthirtyam modified the milestones: v2.9.3, On Deck Oct 7, 2024
@tenthirtyam tenthirtyam force-pushed the docs/vsphere_virtual_machine-disk branch from fec006f to 9d2f92a Compare October 8, 2024 16:42
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Oct 8, 2024
`resource/vsphere_virtual_machine`: Updates to fix examples of `disk0` to reflect that during import the disk get set back to default like `Hard Disk 1`.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the docs/vsphere_virtual_machine-disk branch from 9d2f92a to f29303a Compare October 8, 2024 16:44
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 8, 2024
@tenthirtyam tenthirtyam merged commit adf6714 into hashicorp:main Oct 8, 2024
3 checks passed
Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with disks upon restore/snapshot revert
3 participants