fix: add vm to existing vm group #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider
burnsjared0415
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
1997e0f
to
235bf53
Compare
burnsjared0415
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
235bf53
to
9ceaafe
Compare
I have added code to allow for existing groups to be updated with new vm's, this new code needs cluster import to be ran first on vm group. hashicorp#1878 Signed-off-by: Jared Burns <[email protected]>
burnsjared0415
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
9ceaafe
to
d9e15d2
Compare
tenthirtyam
changed the title
tenthirtyam
added
area/clustering
Updates `r/sphere_compute_cluster_vm_group` to allow for additional virtual machines to be adding or removed from a VM Group. Ref: hashicorp#1878 Signed-off-by: Jared Burns <[email protected]>
tenthirtyam
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
d9e15d2
to
689410b
Compare
burnsjared0415
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
37300c4
to
8956103
Compare
…re-provide' of https://github.com/burnsjared0415/terraform-provider-vsphere into bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
burnsjared0415
force-pushed
the
bug/Failed-to-add-servers-to-an-exist-vm-group-in-vsphere-provide
branch
from
8956103
to
1a357c7
Compare
tenthirtyam
approved these changes
Sep 16, 2024
iBrandyJackson
approved these changes
Sep 16, 2024
tenthirtyam
removed
documentation
|
This functionality has been released in v2.9.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
r/sphere_compute_cluster_vm_groupto allow for additional virtual machines to be adding or removed from a VM Group.Acceptance tests
Output from acceptance testing:
Release Note
r/sphere_compute_cluster_vm_group: Updates to allow for additional virtual machines to be adding or removed from a VM Group.References
Closes #1878