Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for applying existing customization specs #2053

Merged
merged 2 commits into from
Nov 17, 2023
Merged

feat: add support for applying existing customization specs #2053

merged 2 commits into from
Nov 17, 2023

Commits on Nov 16, 2023

  1. [fix hashicorp#1604]Add support for applying existing customization s… 

    …pecs to r/virtual_machine

- added `vsphere_guest_os_customization` data source for existing customization specs
- added `vsphere_guest_os_customization` resource for CRUD operations on
  customization specs
- added customization_spec attribute to VirtualMachineCloneSchema to
  enable `vsphere_guest_os_customization` usage on VM clone
- virtual machine customization and guest os customization are using the
  same code for expanding/flattening specs sent to API
- deleted the file containing the common code regarding guest OS
  customizations shared between VM and customizations
- created e2e tests
- added documentation for `d/vsphere_guest_os_customization` and `r/vsphere_guest_os_customization`
- addressed comments

Testing done:
 - `make build`

 - Verified that the folowing e2e tests pass:
   - TestAccResourceVSphereVirtualMachine_cloneWithDifferentHostname
   - TestAccResourceVSphereVirtualMachine_cloneCustomizeWithNewResourcePool
   - TestAccResourceVSphereVirtualMachine_cloneWithDifferentTimezone
   - TestAccResourceVSphereVirtualMachine_cloneCustomizeForceNewWithDatastore
 - Verified that the newly introduced e2e tests pass

Signed-off-by: Vasil Atanasov <[email protected]>
    @vasilsatanasov @tenthirtyam
    vasilsatanasov authored and tenthirtyam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a92a5b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. [fix hashicorp#1604]Add support for applying existing customization s… 

    …pecs to r/virtual_machine

- added `vsphere_guest_os_customization` data source for existing customization specs
- added `vsphere_guest_os_customization` resource for CRUD operations on
  customization specs
- added customization_spec attribute to VirtualMachineCloneSchema to
  enable `vsphere_guest_os_customization` usage on VM clone
- virtual machine customization and guest os customization are using the
  same code for expanding/flattening specs sent to API
- deleted the file containing the common code regarding guest OS
  customizations shared between VM and customizations
- created e2e tests
- added documentation for `d/vsphere_guest_os_customization` and `r/vsphere_guest_os_customization`
- addressed comments

Testing done:
 - `make build`

 - Verified that the folowing e2e tests pass:
   - TestAccResourceVSphereVirtualMachine_cloneWithDifferentHostname
   - TestAccResourceVSphereVirtualMachine_cloneCustomizeWithNewResourcePool
   - TestAccResourceVSphereVirtualMachine_cloneWithDifferentTimezone
   - TestAccResourceVSphereVirtualMachine_cloneCustomizeForceNewWithDatastore
 - Verified that the newly introduced e2e tests pass

Signed-off-by: Vasil Atanasov <[email protected]>
    @vasilsatanasov @tenthirtyam
    vasilsatanasov authored and tenthirtyam committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    903db0a View commit details
    Browse the repository at this point in the history