Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: vsphere_tag_category #167

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Conversation

vancluever
Copy link
Contributor

This is the data source counterpart to the new vsphere_tag_category
resource. It allows one to pull in an external tag category by name,
using most of the same search call stack as importing.

This is the data source counterpart to the new vsphere_tag_category
resource. It allows one to pull in an external tag category by name,
using most of the same search call stack as importing.
Argument reference was referring to tags and not categories.
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing. Otherwise lgtm


In addition to the `id` being exported, all of the fields that are available in
the [`vsphere_tag_category` resource][resource-tag-category] are also
populated. See that page for further details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts about linking that page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is linked - just above as it's the same link 🙂

@vancluever
Copy link
Contributor Author

Thanks @mbfrahry! Merging now

@vancluever vancluever merged commit 08e1ba5 into master Sep 19, 2017
@vancluever vancluever deleted the f-tag-category-data-source branch September 20, 2017 20:03
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants