Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/virtual_machine: Updated customization and net waiter behaviour #158

Merged
merged 4 commits into from
Sep 14, 2017
Merged

r/virtual_machine: Updated customization and net waiter behaviour #158

merged 4 commits into from
Sep 14, 2017

Commits on Sep 14, 2017

  1. r/virtual_machine: Wait for customization properly, and routed net 

    This is a two-part change that ultimately changes/fixes customization
workflow, but has some other implications:

* First off, we are now waiting for customization to complete by
watching VM events. This is the correct way to wait for customization to
complete as the actual customization task returns very quickly, while
the actual customization process can actually take a few minutes and
fail out-of-band of the initial task.

* Second off, we are now no longer waiting for all interfaces to have IP
addresses during Read, rather we are now waiting for a **routeable**
network. This fixes situations where a template may be configured for
DHCP and gets an autoconfiguration address before actually getting an
IP. This seems to come up during Windows customization especially,
which is what we are trying to fix with this work, so having the event
watch fix without having this one would not fix the issue completely.

* The `wait_for_guest_net` option has also been added, which allows
someone to completely turn off the network waiter. This should help
alleviate some edge cases where NICs have not been configured with IP
addresses, and also allows someone to bypass this behaviour if they are
not configuring a gateway on the VM through either static configuration
of DHCP.

Fixes #140.
    @vancluever
    vancluever committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    f470ba9 View commit details
    Browse the repository at this point in the history

  2. website: Update vsphere_virtual_machine doc 

    * Properly wrap all options.
* Add documentation for wait_for_guest_net option.
    @vancluever
    vancluever committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    353e129 View commit details
    Browse the repository at this point in the history

  3. r/virtual_machine: Add test for customization and net waiter fixes

    @vancluever
    vancluever committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    c4c94dd View commit details
    Browse the repository at this point in the history

  4. r/virtual_machine: Tests for Windows, also move net waiter 

    Adding in the test for all of the customization work we have done, which
mainly crops up with a Windows template.

Also added a new test for DHCP only without waiting on guest networking.
Triggering this test to fail deliberately uncovered an issue with how
the network waiter basically prevents destroy of powered on virtual
machines when we don't have routeable guest network info, so I have
finally just moved the net waiter to Create and Read, which is a more
suitable place for a process that waits for a VM to be ready anyway.
    @vancluever
    vancluever committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    cac4cc2 View commit details
    Browse the repository at this point in the history